search

rurounijones / yarder

JSON based replacement logging system for Ruby on Rails
MIT License
12 stars 8 forks source link

Non-Rails LogSubscriber sources do not output JSON #5

Closed rurounijones closed 11 years ago

rurounijones commented 11 years ago

Doing things like Rails.logger.debug "Help, I need somebody" will result in non-JSON logging.

To get around this we are going to have to create a new base logger as well.

Current questions I have regarding this:

  1. Should these statements be added to the request JSON object (if one exists) or should they be separate? (Possibly separate because log-level may be different). However if they are separate should they still use the rails log_tags if they exist?
rurounijones commented 11 years ago

Should be fixed by 3c92c7bd35ab8237dbfacdb4d609215e8ad38979

Ad-hoc debug messages will be made separate entries

rurounijones commented 11 years ago

Test are passing and no problems in an internal test app. Although the code could be better functionally this appears to be working. So closing this issue