search

rurza / BatFi

Battery charging limiter for macOS.
MIT License
277 stars 33 forks source link

Add power info #3

Closed decodism closed 1 year ago

decodism commented 1 year ago

An attempt to resolve #1.

rurza commented 1 year ago

Holy cow! I didn't noticed your PRs! I will review them in upcoming week :)

decodism commented 1 year ago

I skipped the logging and the UI isn't polished, so feel free to adapt them.

rurza commented 1 year ago

Hey! It looks really good! I will polish it a little bit but great job :)

Screenshot 2023-09-22 at 21 40 04
rurza commented 1 year ago

Merged with 8fb72383165db641ecc3df4abce5259663052c41

decodism commented 1 year ago

You were too quick, I was just rebasing them.

decodism commented 12 months ago

If it's not too much work, wouldn't it be better to merge my rebased PRs instead (still available on my fork)?

rurza commented 11 months ago

@decodism I don't understand. Did you changed anything on it? Because it's already merged. I will take a look :)

rurza commented 11 months ago

@decodism What does the ec60a025cf881b42c290b6f1ff4e82dadf9a4eb4 fix?

decodism commented 11 months ago

I noticed that the reference to the @Default triggered an onAppear (without an onDisappear) at launch, so the observation was running before opening the menu for the first time.

rurza commented 11 months ago

Ah, I know about this issue :) I'm going to refactor the code and fix all issues that I found myself :)