Closed rusandris closed 3 months ago
This is due to round-off errors. In timeseries_to_grid!
, extending the grid borders by 100 consecutive floats doesn't always work
y_max_plus = nextfloat(y_max,100)
y_max_plus > y_max
true
but
y_max_plus - y_min == y_max - y_min
true
A more robust method is needed. x or y values that would determine the grid borders (that fall on the edges) should be excluded from partitioning.
See fix here 968e697
If there are points outside of the predefined grid, symbols can still be bigger than grid_size
or grid_size^2
. In that case, points outside should be discarded/warnings should be thrown.
Moved to #21
See in d318cd1
In some cases, incorrect grid cell assignment happens:
Yet overflow happens and we get a
30
symbol: