Closed rusbrain closed 4 years ago
do we need to keep blank for that field if necessary ?
actually that was required fields, but we can leave empty for this fields when submit form ? here (also creating replay on front)
please advise when this field was made necessary? If it is an uploaded rep file, then YouTube link is not necessary
I fixed this issue.
@widedeveloper u fixed what?? Screenshot
I can't add VOD as well, lol Screenshot
@rusbrain I changed the form only on the frontend part. I’ll fix this asap.
Now the logic is this:
@fun4life1990 .rar, .7z, .zip archives are impossible to upload now. As well as Youtube/ Twitch/ Afreeca videos (VODs).
@rusbrain I have created PR with latest changes for replay. I added new fields like players names and APMs and game date. I added them only for admin panel so you can check new functionality and send me your response. After that I will add these fields to front.
Also I could upload archives since now.
@fun4life1990 Replay upload still not working
@fun4life1990 I can't upload archives
@rusbrain , I just updated server again, Please check now
@widedeveloper Please check yourself, and post a screenshot, that you are able to submit archives. Thanks.
okay I updated server and restart but not working the uploading @fun4life1990 , it's working on your local dev environment correctly ?
There is an actual bug with .rar files upload It happens on client-side MIME re-validation with dropzone.js
There is also a weird bin name collision commit | file | current bin path Please either change that path in service or the binary name to match
I've added all generic MIMEs but an archives still could have an octal headers so maybe we should remove that validation
It certainly makes no sense to do such rechecks on client side. Dropdown.js MIMEs were replaced with just a dot extensions e.g. '.rar' '.7z'
Please clear client-/server-side cache and re-insure the fix
@nl169 I wrote cli-command for cleaning db from unpublished replay files replays:clean_files
@fun4life1990 Replay archive upload still not working. Would you consider a button or alike option to change the uploader from the previous format (all-manual data) and automatic format (parsed data). All-manual would have allowed adding archives and many more.
@rusbrain Could you please give me archive which you upload, so i could reproduce this?
@fun4life1990 shared via upwork
Screenshot