search

ruscalworld / fabric-exporter

Fabric mod that adds a Prometheus exporter with general metrics of your server
https://modrinth.com/mod/fabricexporter
MIT License
33 stars 6 forks source link

Export more stats + compatibility with other dashboard #6

Closed Volkor3-16 closed 1 year ago

Volkor3-16 commented 1 year ago

I found this dashboard while looking for a dashboard and mod for a Forge modded server, and by the looks of it, it looks to be a much better dashboard than the one we've got here.

Would it be too much to ask to rename all the exported values to match that dashboard? (and export the same stats)

Hell, even if you don't, having JVM stats would be very nice to see for debugging

ruscalworld commented 1 year ago

Dashboards in Grafana are just a way to display data collected by Prometheus, so they should be adapted to show this data, and not vice versa. You can use any dashboard you want, but you should modify it such way that it will use metrics collected by this mod in the format that this mod uses.

I will think about exporting JVM stats. I think it will be nice.

Volkor3-16 commented 1 year ago

should be adapted to show this data, and not vice versa.

I am aware, I'm more-so saying so I can have all of my servers (running a different mod exporter) show on the same dashboard. I probably should have probably mentioned that in the first post :/

It's a small thing and would require a lot of work so It's understandable why you wouldn't.

ruscalworld commented 1 year ago

FabricExporter now comes with JVM metrics provided by simpleclient_hotspot package.

Forge mod that you've referenced uses the same package, so its dashboard even will not require any changes in part of JVM metrics for usage with FabricExporter.