Maybe number position doesn't match number buttons on 4x4 grid

rusdewey / mathdoku

Automatically exported from code.google.com/p/mathdoku

0 stars 0 forks source link

Maybe number position doesn't match number buttons on 4x4 grid #103

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

Revision 157:
This seems a little pedantic, but I thought it looked strange when I first saw 
it. With "Maybes in 3x3 Grid" option turned on, apart from the 4x4 game, the 
number buttons are placed in a grid that is 3 columns wide, similarly with the 
maybe cell values i.e. the position of the maybe value in the cell matches the 
button position, like:

1 2 3
4 5 6
7 8 9

However, with the 4x4 grid, the number buttons are now in a 2x2 square i.e.
1 2
3 4

which doesn't match the maybe number positions in the cell

1 2 3
4

I think it would be good to keep them consistent. I don't have a preference 
which one is changed (maybe value positions or buttons positions).

Original issue reported on code.google.com by em...@srlee.com on 26 Mar 2013 at 9:17

GoogleCodeExporter commented 9 years ago

Original comment by em...@srlee.com on 26 Mar 2013 at 9:18

Added labels: Priority-Low
Removed labels: Priority-Medium

GoogleCodeExporter commented 9 years ago

You're right. This should be consistent.

Original comment by paul.din...@gmail.com on 26 Mar 2013 at 3:48

Changed state: Accepted

GoogleCodeExporter commented 9 years ago

Solved. The option "Maybes in 3x3 grid" is renamed to "Maybes in grid". Note 
that on small screens in portait mode a different grid id used compared to the 
landscape mode. In all cases the grid for the maybe values is now consistent 
with the layout of digit buttons.

Original comment by paul.din...@gmail.com on 27 Mar 2013 at 9:13

GoogleCodeExporter commented 9 years ago

This issue was closed by revision r166.

Original comment by paul.din...@gmail.com on 27 Mar 2013 at 9:16

Changed state: Fixed

GoogleCodeExporter commented 9 years ago

Renaming of option is commited in revision167.

Original comment by paul.din...@gmail.com on 27 Mar 2013 at 10:14

GoogleCodeExporter commented 9 years ago

Tested Revision 198: Maybe numbers now match positioning of buttons (tested 4x4 
game and also 9x9 game on small device). Option label rename also makes sense.

Original comment by em...@srlee.com on 2 Apr 2013 at 7:38

Changed state: Verified