Closed rusefillc closed 1 year ago
another strange error https://github.com/rusefi/rusefi_documentation/pull/482/commits/2f7a601519c0793d37e3e8e2fda7673575a5b61e
update: this was clarified at https://github.com/rusefi/rusefi_documentation/pull/483
What's strange about that? It's telling you what's wrong.
What's strange about that? It's telling you what's wrong.
Why do we care? What is the value of those rules?
I should have looked closer; too many variants of MD for me to keep straight -- this is why we care I think:
Linting helps us be sure that we are writing standard Markdown, which is most likely to be rendered correctly in all our outputs.
@chuckwagoncomputing I absolutely support lint in general
What I am asking is
We can disable rules. I haven't tested, so I don't know if any of our "outputs" care about a newline at the end of the file. What editor did you use to create that file? Normally editors save files with a newline at the end.
Another option would be to automatically fix all fixable rule violations. markdownlint-cli2 has this option and I tried it successfully already.
@rusefillc shall "automatically fix all fixable rule violations" be enabled? in case not, please just close this issue
It's not just a case of enabling it - it would have to commit and push the change. I'm not sure how that would work with a pull request for example.
As Andrey did not respond, I'd believe it's no longer an issue or he lost interest. In either case I'm inclined to just close it.
fenced-code-language is a weird one
I love it as it makes programming language used perfectly visible but without proper tooling its a pain. Therefore I always use the markdownlint extension in my IDE
no surprise because its getting abused. These files (https://github.com/rusefi/rusefi_documentation/tree/master/wip) should never show up in doc repo as md files!
https://github.com/rusefi/rusefi_documentation/actions/runs/4608587957/jobs/8144555821
Do we see value in both of these errors? I can maybe see some merit in MD041 but MD047 why do we torture ourselves?