rush00121 / SimpleTodo

0 stars 0 forks source link

Review my prework app #1

Open rush00121 opened 9 years ago

rush00121 commented 9 years ago

I have completed the prework app as described in the document http://courses.codepath.com/snippets/intro_to_android/prework

Can you please review my code and provide feedback. In the meantime, I will work on the extra features in the forthcoming days. /cc @codepathreview @codepath

nesquena commented 9 years ago

Rushabh,

Looks good! This was intended in part to give you an introduction to the general rhythm of this course. The course is entirely project based with an app being assigned each week and then due the following week. Each project builds on the last to help each engineer to learn all practical Android development and best practices as quickly as possible. We also do a code review for each submitted project.

The next step is to continue working on extensions to your todo app and to schedule a short 5-10 minute phone conversation here. Navigate to today's date and onward from there and choose a 15-minute slot. Let us know if none of those times work.

Once you select a slot, can you make sure to include best number to reach you at? Look forward to chatting soon!

rush00121 commented 9 years ago

/cc @codepathreview @codepath I have updated the persistence mechanism to use sqllite instead of storing it to a file.

nidhi1608 commented 9 years ago

Looks good. Hope you found this exercise useful as an introduction to android app development.

rush00121 commented 9 years ago

I have added a few more extensions /cc @codepathreview @codepath

1) I have used a custom adapter for displaying data on the listView. 2) The Item data model now also supports a due date for the task. 3) The due date for the task is shown on the listView using a custom view. 4) The due date can be entered using a DatePickerDialog . The edit dialog also has a DatePickerDialog for editing the date.

nidhi1608 commented 9 years ago

Looks good. Glad you were able to work on the extensions.