search

rushiiMachine / osu-patcher

osu! patcher for making playing with Relax more enjoyable
GNU General Public License v3.0
15 stars 3 forks source link

Proper project attribution #15

Closed klonerovsky closed 2 months ago

klonerovsky commented 2 months ago

Im writing my osu switcher and I'm using your patcher, I would like to discuss cooperation with you. I'm leaving a link to your patcher, but I don't know how you feel about it!

rushiiMachine commented 2 months ago

you can ask anything here

klonerovsky commented 2 months ago

But I already found your discord, maybe we'll talk there?

klonerovsky commented 2 months ago

you can ask anything here But if you want to stay here - okay, no problem

rushiiMachine commented 2 months ago

my discord is for personal use

klonerovsky commented 2 months ago

my discord is for personal use

Ok, I see. So I'm writing Okayu Loader (https://github.com/takumoyoshi/OkayuLoader) on C# winui3. It's a tool that runs osu with devserver flag, I think it's better to have one program rather then have a thousands of lnk for every server. In future I will code a function, that runs osu with auto logged in account that user choosed (when you are switching between servers osu don't remember Your account and password). I also added feature that runs osu with your patcher. I don't know what should I do. I already added link to your patcher repo, but I also added compiled patcher in releases. I don't want to make thing when user must compile your patcher by himself, but I don't think that pin your patchee to releases is a good idea, because users will not go your repo and see who made patcher. What should I do? P.S. Im sorry about my English skills. Im from Russia and time in Moscow is 2:48 am, I'm not thinking straight anymore

rushiiMachine commented 2 months ago

no worries

when you are switching between servers osu don't remember Your account and password

I have a tool for that, it's pinned on my profile if you want to take a look.

You can include my project in releases as long as you use the same license (done) and give proper credit.

image

A hyperlink to this repository in the description of that button would suffice.

klonerovsky commented 2 months ago

Thank you very much! I will include patcher in releases but I will make hyperlink to you repo in patcher card. Thank you!

rushiiMachine commented 2 months ago

Also, I strongly urge against this

Download the latest .msix installer from Release page and then trust OkayuLoader certificate. Download Patcher.7z and extract it in osu! folder.

Not only could you accidentally overwrite game files, it clutters your game directory and makes it unmanagable. Also, just avoid msix, it's a pain in the ass. I don't like trusting random certificates and I doubt others would either. Just build a standalone version that doesn't require any installation.

klonerovsky commented 2 months ago

Okay... So I will see how can I make a standalone version of winui3 apps... And I also change path to patcher from osu! folder to (for example) user documents or home directory

blackwolf660 commented 2 months ago

@rushiiMachine is it possible to use the compiled version for auto-installation for Okayu Loader (https://github.com/takumoyoshi/OkayuLoader)?

rushiiMachine commented 2 months ago

as long as it complies with the aforementioned terms