search

rushisangani / BiometricAuthentication

Use Apple FaceID or TouchID authentication in your app using BiometricAuthentication.
MIT License
831 stars 110 forks source link

swift 4 migration #3

Closed irshadpc closed 7 years ago

irshadpc commented 7 years ago

swift 4 migration

rushisangani commented 7 years ago

Minimum deployment target could not be set to iOS 11. It won't work with iOS 10.

irshadpc commented 7 years ago

@rushisangani We can release separate framework for swift 3 and swift 4. If you like i will do for the same.

rushisangani commented 7 years ago

I would happy to do that. But I am curious to know, which version should I update in Cocoapods - support for Swift 3.2 or 4.0 I guess we can't support both simultaneously using same cocoa pod version.

irshadpc commented 7 years ago

@rushisangani Do the versioning for swift 3 and swift 4 on pod spec.

rushisangani commented 7 years ago

@irshadpc could you please do the necessary setup and framework changes to support both swift 3 and 4. I would happy to merge your pull request. Also, please provide what should be done in podspec file to support both versions.

irshadpc commented 7 years ago

@rushisangani Check this https://github.com/CocoaPods/CocoaPods/issues/6791