search

rushmorem / publicsuffix

An implementation of Mozilla's Public Suffix List in Rust
MIT License
97 stars 17 forks source link

remove Box in ListNode & 2018 edition #29

Closed leshow closed 3 years ago

leshow commented 4 years ago

There's a superfluous Box in the trie-like data structure ListNode. HashMap already provides indirection, so you don't actually need to Box it.

I also bumped the edition to 2018, ran rustfmt, and used criterion for your benchmarks so you don't have to run nightly anymore. If you'd like like the Box change I can just that in a separate PR, but I thought there's no reason not to just submit this all in one!

leshow commented 3 years ago

Thanks for the merge! Any timeline on a release?