search

ruslansk / mongoose

Automatically exported from code.google.com/p/mongoose
MIT License
0 stars 0 forks source link

consider including ws2tcpip.h when compiling for windows #331

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. compile and link for windows, if you use some odd macro, it won't work.

What is the expected output? What do you see instead?
everything is fine

What version of the product are you using? On what operating system?
HEAD, winblows XP

Please provide any additional information below.

ws2tcpip.h contains some useful defines, not available in winsock2.h. This 
allows mongoose hackers to debug/add functionality to mongoose without having 
to do the include manually. It should be included AFTER winsock2.h.

http://support.microsoft.com/kb/257460

Original issue reported on code.google.com by janez...@gmail.com on 29 Mar 2012 at 7:40

GoogleCodeExporter commented 9 years ago 
Submitted 
http://code.google.com/p/mongoose/source/detail?r=8cdb0d40ce442adc573eebe4875203
a8d8542f66, thank you

Original comment by valenok on 29 Mar 2012 at 10:10

GoogleCodeExporter commented 9 years ago 
I am afraid the fix is incorrect. You need to either move the include
into the common windows section as the last include or move it into
the win32-only section, as the last include.

Original comment by janez...@gmail.com on 30 Mar 2012 at 8:05

GoogleCodeExporter commented 9 years ago 
Patch please :-)

Original comment by valenok on 30 Mar 2012 at 9:10