search

ruslanskorb / RSKImageCropper

An image cropper / photo cropper for iOS like in the Contacts app with support for landscape orientation.
MIT License
2.45k stars 471 forks source link

version 2.1.0 broke react-native-image-crop-picker #208

Closed brandonpearcy closed 5 years ago

brandonpearcy commented 5 years ago

See https://github.com/ivpusic/react-native-image-crop-picker/issues/850 for a detailed reported. I have been able to confirm that the 2.1.0 release broke cropping while zooming on iOS. The cropRect field in the response is bogus. Since I do not use RSKImageCropper directly, can you confirm that zooming+cropping is working as expected? If so, what changed between 2.0.1 and 2.1.0 that might cause clients to break?

ruslanskorb commented 5 years ago

Hi @brandonpearcy,

I can confirm that zooming+cropping is working as expected in the latest version of RSKImageCropper.

As far as I can see react-native-image-crop-picker library has additional post image processing. Check with its author, whether it works correctly. Probably, implementation of the RSKImageCropViewControllerDataSource methods should also be checked.

Also, I would like to ask you to try to reproduce the problem directly in RSKImageCropper. If you can do this, I will be able to help.

ruslanskorb commented 5 years ago

@brandonpearcy Feel free to reopen the issue if you succeed in reproducing the problem in RSKImageCropper.