search

rusq / slackdump

Save or export your private and public Slack messages, threads, files, and users locally without admin privileges.
GNU General Public License v3.0
1.51k stars 70 forks source link

Attachments downloaded in standard export although no -download flag #232

Closed jo-chemla closed 1 year ago

jo-chemla commented 1 year ago

Describe the bug When doing a standard export, then attachments are downloaded although there is no additional -download flag in the command.

To Reproduce Steps to reproduce the behavior: Run slackdump like this 

slackdump -export my-workspace -export-type standard

Expected behavior Attachments should not be present.

Desktop (please complete the following information):

jo-chemla commented 1 year ago

Note it might as well be useful for slackdump to allow for the download of all attachments or only these present in private channels/DMs - not these present in public channels. Maybe via a flag like -download [all (default) | private-only | public-only]

rusq commented 1 year ago

Hey @jo-chemla this is expected behaviour, and a design flaw: have a look at this #227 where I explained why this happens.

Also, thank you for a great suggestion of the download behaviour, I'll create a separate issue for it.

jo-chemla commented 1 year ago

Thanks for getting back! I also did not notice the no-download behavior - maybe the doc could clarify there are these 3 modes

rusq commented 1 year ago

V3 will have updated logic, and this won't be necessary, I just need to find some time to finish it 😂