rusq / slackdump

Save or export your private and public Slack messages, threads, files, and users locally without admin privileges.
GNU General Public License v3.0
1.51k stars 70 forks source link

Goreleaser improvements #295

Closed arran4 closed 2 months ago

arran4 commented 3 months ago

I did this mostly to include the man page. But this also updates the versions of the actions used in github actions, and uses npmf to create packages.

You can see a sample of the files generated here:

https://github.com/arran4/slackdump/releases/tag/v2.5.8-test4

Also Goreleaser 2 is released https://goreleaser.com/blog/goreleaser-v2/

Thus I got:

/opt/hostedtoolcache/goreleaser-action/2.0.1/x64/goreleaser release --clean
  • starting release...
  • only configurations files on  version: 2  are supported, yours is  version: 0 , please update your configuration

And had to address it.

I am not sure of the purpose of having ACTIONS_TOKEN since there is an automatically generated one GITHUB_TOKEN (which I needed to use in order to test this.)

Subject: [PATCH] 
---
Index: .github/workflows/release.yml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
--- a/.github/workflows/release.yml (revision c9f8103d3d4e72b7fb1e61649f196f57c1c5bb17)
+++ b/.github/workflows/release.yml (revision 38400ad41ef563cce3191ca18cecc3d68b22618c)
@@ -28,4 +28,4 @@
           version: latest
           args: release --clean
         env:
-          GITHUB_TOKEN: ${{ secrets.ACTIONS_TOKEN }}
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

I would recommend changing it if there isn't another reason for it.

rusq commented 3 months ago

The ACTIONS_TOKEN serves the same purpose as GITHUB_TOKEN, the reason it is there - at the moment of creating this file, I was unaware that GITHUB_TOKEN automatically propagated by Github, so it's safe to replace ACTIONS_TOKEN with GITHUB_TOKEN with no adverse consequences.

rusq commented 3 months ago

Tests are failing, they never worked on v3 in CI yet.

arran4 commented 3 months ago

Tests are failing, they never worked on v3 in CI yet.

Interesting. I will take a look when I can.

arran4 commented 3 months ago

Test failing has been replicated locally too.

arran4 commented 3 months ago

Sorry misread -- I guess leave it until the the tests are fixed then I will resync and you can re-approve.

What did you want me to do with the TOKEN ?

rusq commented 3 months ago

Yes, master tests are broken in a sense that they require some fixtures only present locally on my computer, haven't gotten around to fix that before real life hit me recently. If you could replace ACTIONS_TOKEN with GITHUB_TOKEN I would greatly appreciate it, and thank you! I'll get around to fix the tests soon, will merge this PR, because I think it's useful.

arran4 commented 3 months ago

@rusq as requested: 38400ad41ef563cce3191ca18cecc3d68b22618c