russbiggs / spot-the-box

Web application to crowd source the status of USPS Collection Boxes
MIT License
12 stars 3 forks source link

Handle other kinds of issues on boxes #10

Open mikelmaron opened 4 years ago

mikelmaron commented 4 years ago

One idea -- need "other problem" button -- on social media seen boxes with padlock on them.

frizatch commented 4 years ago

I'm wondering if it's simpler/better to mark locations as "functional box" or not (the "not" being for whatever reason)... but this depends on the frequency of the data updates, since it's easier to unlock a box than install a new one.

Disregard - having a category specifically for "removed" makes sense... just more complicated. :)

mikelmaron commented 4 years ago

There's at least two additional situations to handle

@russbiggs what do you think about adding 2 more buttons?

ranatalus commented 4 years ago

Are there any statuses we care about other than: --Box present --Box removed --Box relocated nearby --Box inoperable (locked/damaged)

russbiggs commented 4 years ago

i'm wondering if some of these are not mutually exclusive (but not all). Particularly around relocation. a box can be relocated AND locked. I guess relocated also means box present so those two cant go together. I'm ok with this but might need to consider status as an array and how we allow statuses.

russbiggs commented 4 years ago

@mikelmaron upon re-reading your last comment I think your descriptions handle the overlap and make my point moot. When adding the buttons i'll make sure they have the distinctions you've listed

frizatch commented 4 years ago

I really like the box is present but not-functional button option.

The second button could use some sort of parameter of distance-of-displacement for it to be considered the "same box," perhaps. Or we just trust people that use this app to be reasonable about that decision and cross fingers people don't get subtly malicious.

ranatalus commented 4 years ago

@frizatch if there’s one thing I’ve learned in my years on the internet, it’s “never trust random users to not be malicious” :)

russbiggs commented 4 years ago

I'm struggling with the box location issue option. As far I can tell a lot of the points, at least in Albuquerque, are not super accurate which could lead to too much focus on the placement of the box and not its operational status. For example none of these boxes are in the correct position at the Albuquerque main Post Office:

Screen Shot 2020-08-18 at 3 20 03 PM

I'm thinking about distinguishing the "type" a bit before for Post Office Lobby boxes in more plain language and maybe a hint like "check inside post office lobby".

Thoughts?

frizatch commented 4 years ago

Could there be language that covers many options? Something like: "Present, or replacement/alternate option within view of location"

russbiggs commented 4 years ago

out of order/ locked implemented in 658f0f2. I'll keep this issue open for discussion about location issues for now

treestryder commented 4 years ago

What does the "Save" button do?

russbiggs commented 4 years ago

The Save button saves the status and POSTs it to the API for the given collection box.

treestryder commented 4 years ago

So... that why the map has yet to update, for the dozen or more boxes I've surveyed.

After 35 years, mostly as a low level computer tech, you would think I would be better at this.

russbiggs commented 4 years ago

@treestryder can you open a new issue with the outlet ID of some of the points you have mapped but that aren't updating? Everything is updating fine for me but I would like to identify the issue you're experiencing.

treestryder commented 4 years ago

I had misinterpreted the "Save" as a fourth possible state for a post box. Based partly on the assumption that only a single button push would be needed.

russbiggs commented 4 years ago

Ah I see your comment was a statement not a question. I guess i was reading too quickly!