search

russell-archer / StoreHelper

Implementing In-App Purchases with StoreKit2 in Xcode 13 - 15 using SwiftUI, Swift 5.7 - 5.9, iOS 15 - 17 and macOS 12 - 14. Also supports tvOS and visionOS.
MIT License
410 stars 48 forks source link

Revocation not handled properly #33

Closed drallgood closed 1 year ago

drallgood commented 1 year ago

While investigating a different issue (subscription purchases don't seem to work correctly.. looks like an iOS bug) I stumbled upon this line: https://github.com/russell-archer/StoreHelper/blob/267b0342d8fed38d68f1a3a57f5add38602a10c8/Sources/StoreHelper/Core/StoreHelper.swift#L540

shouldn't this be != nil? i.e. it's added unless it was revoked?

russell-archer commented 1 year ago

Well spotted! You're right. I accidentally introduced this bug a few days ago. Thanks very much for the feedback. Fixed!

drallgood commented 1 year ago

Well spotted! You're right. I accidentally introduced this bug a few days ago. Thanks very much for the feedback. Fixed!

Awesome! Thanks for the quick fix!