search

russellbanks / Komac

The Community Manifest Creator for WinGet
GNU General Public License v3.0
213 stars 16 forks source link

[Bug]: `komac update` removes `AppsAndFeaturesEntries` in `Installers` #604

Closed rakleed closed 2 months ago

rakleed commented 6 months ago

Is there an existing issue for this?

What happened?

komac update -u https://download.gigabyte.com/FileList/Utility/GCC_24.05.01.01.zip -i GIGABYTE.GigabyteControlCenter -v 24.05.01.01

AppsAndFeaturesEntries should remain the same as in the previous version, but komac simply removes this property.

OpenWaygate commented 4 months ago

It also removes Commands field from .installer.yaml.

I missed Commands field when I komac new, but I add it manually in a pr(release 0.8.5).

However, in my pr of release 0.9.0, the Commands field disappears.

I use vedantmgoyal2009/winget-releaser@v2.

russellbanks commented 4 months ago

I use vedantmgoyal2009/winget-releaser@v2.

WinGet Releaser currently uses Komac v1. WinGet Releaser will update to Komac v2 when Komac v2.3.0 is released.

russellbanks commented 2 months ago

AppsAndFeaturesEntries should not remain the same as in a previous version by default. DisplayVersion can often change between releases and keeping one for a previous version can cause incorrect matching. Where it can, Komac will identify ARP entries for a given installer. In very specific edge cases, I would suggest manually editing the manifest in Komac's editor.