russellbanks / Komac

The Community Manifest Creator for WinGet
GNU General Public License v3.0
213 stars 16 forks source link

[Bug]: RelativeFilePath not updated in current nightly build #634

Closed a-mnich closed 4 months ago

a-mnich commented 5 months ago

Is there an existing issue for this?

What happened?

In the current nightly build the RelativeFilePath doesn't seem to be correctly updated.
I only experienced this with a single package linked below and wasn't able to find another package where I can reproduce this issue.
With komac 2.2.1 it still works as usual.

komac-nightly-x86_64-pc-windows-msvc.exe update --version 2.10.1 --urls https://github.com/EdgeTX/edgetx/releases/download/v2.10.1/edgetx-cpn-win64-v2.10.1.zip --dry-run EdgeTX.Companion

Komac nightly:
grafik

Komac 2.2.1:
grafik

russellbanks commented 4 months ago

Thanks for reporting! I've changed it so that if the file name or path changes within the zip, a levenshtein string comparison (returns the minimum number of insertions, deletions, and substitutions required to change one string into the other) is done to find the file path that is the most similar.