search

russellbanks / Komac

The Community Manifest Creator for WinGet
GNU General Public License v3.0
213 stars 16 forks source link

[Bug]: No release was found with tag of download #668

Closed vikingnope closed 3 months ago

vikingnope commented 4 months ago

Is there an existing issue for this?

What happened?

Hiya, just got this error, anyway this could be fixed or bypassed?

image

vedantmgoyal9 commented 4 months ago

Try using https://github.com/Vencord/Installer/releases/download/v1.4.0/VencordInstallerCli.exe

vikingnope commented 4 months ago

Weirdly enough that works, but I would prefer not to use that link since it says 1.4.0

vedantmgoyal9 commented 4 months ago

Winget prefers to use a versioned URL, not a permanent URL which always redirects to the latest release. It breaks manifests with "installer sha256 hash mismatch" and users are required to explicitly override the error, which becomes inconvenient if it occurs often. Some of the cases where it is fine are nightly releases of software, or where publisher doesn't provide version-specific URL.

vikingnope commented 4 months ago

Yep I fully agree with you on this and I understand it, but the thing is with the other link, we will get the same issue anyways, for some reason it acts also as a "latest version" link (Don't know why projects do this), so it isn't an issue with Komac really and truly. I thank you for your continuous support anyways :)

russellbanks commented 3 months ago

I could possibly make it so that if you give komac the 'latest' link it will turn it into a versioned link.

russellbanks commented 3 months ago

I could possibly make it so that if you give komac the 'latest' link it will turn it into a versioned link.

Going to https://github.com/Vencord/Installer/releases/latest/download/VencordInstallerCli.exe actually redirects to https://github.com/Vencord/Installer/releases/download/v1.4.0/VencordInstallerCli.exe so if the url has latest/download, I would just need to follow the redirect by one hop.