search

russellcardullo / go-pingdom

No longer maintained: Pingdom API access from Go
MIT License
29 stars 75 forks source link

Modify check without removing values #27

Open RafPe opened 6 years ago

RafPe commented 6 years ago

This PR ensures that we have method which allows update without removing of current values within HTTP checks.

russellcardullo commented 6 years ago

This is okay for now, but I think longer term would be better to have a single method that accepts optional values. So if we merged this it would really be short term until we get a chance to rework everything to be optional.

I'll have some time to look into that next week.

RafPe commented 6 years ago

@russellcardullo I completely agree with you that this is temporary. I believe we could help out in work towards making certain things optional.

If you could merge it this week that would really help us out :)