russellcardullo / terraform-provider-pingdom

No longer maintained: Terraform provider to manage pingdom resources
MIT License
120 stars 108 forks source link

Contact Validation error when not passing the paused flag #111

Open rogerioefonseca opened 2 years ago

rogerioefonseca commented 2 years ago

Terraform Core Version 1.3.2

Pngdom-provider Version 1.1.3

Affected Resource(s) pingdom_contact

Expected Behavior When running apply, it would need to create the contacts pingdom_contact with both LOW and HIGH severity.

Actual Behavior When running plan, it shows that it will create a contact with both LOW and HIGH severity but in the apply, it triggers an error complaining about that.

Relevant Error/Panic Output Snippet

pingdom_contact.second_contact: Creating...
╷
│ Error: You must provide both a high and low severity notification method
│
│   with pingdom_contact.second_contact,
│   on main.tf line 26, in resource "pingdom_contact" "second_contact":
│   26: resource "pingdom_contact" "second_contact" {
│
╵

Steps to Reproduce Copy the example code:

resource "pingdom_contact" "second_contact" {
  name   = "janedoe"
  paused = true

  email_notification {
    address  = "test@test.com"
    severity = "LOW"
  }

  email_notification {
    address  = "test@test.com"
    severity = "HIGH"
  }
}

Run teraform apply tf apply --target=pingdom_contact.second_contact

Would you like to implement a fix? I would like to implement a fix, but I will wait for interactions and then see if it makes sense to contribute.

cgroschupp commented 2 years ago

this is already fixed in this commit: https://github.com/russellcardullo/terraform-provider-pingdom/commit/b1b6487983b14bf02865ab1389bd145f6154ea40

so wait for a new release.

rogerioefonseca commented 2 years ago

This repo does not look to be maintained anymore. We might need to fork and maintain it.

rogerioefonseca commented 2 years ago

This repo does not look to be maintained anymore. We might need to fork and maintain it.

Anyways, this is still open and needs to be included in a new release