pingdom_check: Monitor SSL/TLS certificate

russellcardullo / terraform-provider-pingdom

No longer maintained: Terraform provider to manage pingdom resources

MIT License

120 stars 108 forks source link

pingdom_check: Monitor SSL/TLS certificate #69

Open dzoellner opened 4 years ago

dzoellner commented 4 years ago

Pingdom has options to monitor SSL/TLS certificates and alert when the certificate is some number of days away from expiring. It would be nice to control these settings from terraform.

justincmoy commented 4 years ago

I created a branch which adds both of these options: https://github.com/justincmoy/terraform-provider-pingdom/tree/ssl-certificate-verify.

One caveat is it seems like the default for Monitor SSL/TLS certificate is true, so I kept that in the terraform provider, but broke it in the underlying library.

Not sure when I can get around to putting up PRs for this.

camerondavison commented 4 years ago

thanks @justincmoy anything that we could help with to get this merged?

justincmoy commented 4 years ago

I created https://github.com/russellcardullo/go-pingdom/pull/56 to update the library. Once that's approved/merged, I can put up the PR for the terraform provider.

camerondavison commented 4 years ago

Just noticed that it looks like go-pindom update got accepted and merged

bobthebuilderberlin commented 3 years ago

Would be very happy to see this also in the official release. bump.

justincmoy commented 3 years ago

I'll take a look at this. I never got around to testing it with the changes to this provider to use the v3.1 Pingdom API.