search

russellhaering / goxmldsig

Pure Go implementation of XML Digital Signatures
Apache License 2.0
154 stars 127 forks source link

Use canonicalization from sig info #61

Closed pboyd04 closed 4 years ago

jhlange commented 4 years ago

@russellhaering @paulquerna-okta Do you see an issue with merging this? We've run into a use-case for it in my organization as well.

Digging a little bit, it seems others have, too: https://github.com/sourcegraph/sourcegraph/issues/13032 referenced to: https://github.com/russellhaering/goxmldsig/issues/43

pboyd04 commented 4 years ago

@jhlange I've got this and a few other fixes in my version of the module at https://github.com/pboyd04/goxmldsig if you want to use that instead

russellhaering commented 4 years ago

Thanks for the contribution! This looks good to me.