search

russellhaering / goxmldsig

Pure Go implementation of XML Digital Signatures
Apache License 2.0
154 stars 127 forks source link

Support for http://www.w3.org/2001/10/xml-exc-c14n\#WithComments #74

Closed simonbrynych closed 3 years ago

simonbrynych commented 3 years ago

This PR includes support for http://www.w3.org/2001/10/xml-exc-c14n\#WithComments

Follow-up PR from https://github.com/russellhaering/goxmldsig/pull/38 which is deprecated.

@russellhaering can you please take a look at it? I'm open to any suggestion and I would highly appreciate your feedback/approve/merge. Thanks buddy

simonbrynych commented 3 years ago

Closing as Tobi's PR is fixing the PR properly.

https://github.com/russellhaering/goxmldsig/pull/72

tomstaijen commented 3 years ago

Closing as Tobi's PR is fixing the PR properly.

72

Maybe then merge that...