search

russelllab / kinaseResistance

A method to predict activating, deactivating and resistance mutations in kinases
http://activark.russelllab.org
GNU General Public License v3.0
1 stars 0 forks source link

change Windowsize #77

Open tschmenger opened 1 year ago

tschmenger commented 1 year ago

Robs comment: ""Window size" is not window size : I'd keep it but have the number be 2x + 1 (i.e. rather than saying + or - X residues as it is)."

tschmenger commented 1 year ago

I am not sure I agree with this @gurdeep330. Maybe we can change the term? Instead of Windowsize we call in Point of View, or just Selection? Right now I think it is quite easy for the user to adjust the settings to see what we know of an interesting position 28 positions c-terminal of the mutation. If we make the proposed change the user would have to make some weird calculation to decide the setting in order to arrive at the same result. I don't like this and I think the argument stems from using the term Windowsize, which is apparently written in stone what it has to mean.

tschmenger commented 1 year ago

I saw that you @gurdeep330 applied the change suggested by Rob. I really don't like this, though. In terms of user friendliness this is not an improvement.

For instance: A user had to select Windowsize 30 before if they wanted to know what we know about position 110 (when the input position was 80) of their protein of interest. Robs suggestion will now have the user select... 61, is that right? I don't see how this is an improvement.

I vote to change the term we used before/make it more clear that the selected number is +/- around the position of interest.

Maybe we can try to discuss this again with Rob? What do you think?