search

russelltg / wl-screenrec

High performance wlroots screen recording, featuring hardware encoding
Apache License 2.0
266 stars 9 forks source link

Why does it default to AVI rather than MKV or such? #12

Closed colemickens closed 1 year ago

colemickens commented 1 year ago

I was rather surprised to see this output an AVI. I haven't seen an AVI in the wild for ages. Is there a reason for using it over MKV?

russelltg commented 1 year ago

Yeah, great question--avi was just the first container format I got to work (for details of ffmpeg being tricky to use), but they should all work now.

I generally use it with mp4 for good compatibility

russelltg commented 1 year ago

Is there a reason you'd choose mkv over mp4 for default?

colemickens commented 1 year ago

I think I'm used to MKV from other video purposes where HEVC is used, but I don't know if that's relevant here. I'm not sure I could offer reasoning for one over the other.

russelltg commented 1 year ago

I see--ffmpeg lists AVC as the default codec for mkv and currently this package only supports AVC.

Would you benefit from HEVC support? I'm happy to add it if there's interest.

russelltg commented 1 year ago

Added support for other codecs and changed default to mp4

colemickens commented 1 year ago

Thanks @russelltg !