search

russelltg / wl-screenrec

High performance wlroots screen recording, featuring hardware encoding
Apache License 2.0
266 stars 10 forks source link

Geometry positioning ignored, screen recording starts at top left no matter what #52

Closed ThatOneCalculator closed 5 months ago

ThatOneCalculator commented 5 months ago

As the title says, doing something like wl-screenrec -g "$(slurp)" -f "$HOME/Videos/screenrec_$(date +'%s').mp4" --low-power=off and having $(slurp) be a region like 1528,156 1110x712 gets the size right but completely ignores the positioning, leaving it to record that size at the top left.

ThatOneCalculator commented 5 months ago

I think this is caused by https://github.com/russelltg/wl-screenrec/commit/eabd6dd870961475f10fb59524c27e8c1aff92c2 , seeing as how it completely ignores x and y

ThatOneCalculator commented 5 months ago

Actually, even after reverting it, the behavior still happens, so I'm not sure what's causing it...

russelltg commented 5 months ago

That commit doesn't ignore x and y, it just removes the cast as it's not needed anymore

ThatOneCalculator commented 5 months ago

Ah. Still not sure why it's being ignored in practice though.

russelltg commented 5 months ago

Yeah, it's super strange. My guess is an issue with your vaapi driver of sorts, but not entirely sure

russelltg commented 5 months ago

Probably a dup of #47, what does messing with exact give?

ThatOneCalculator commented 5 months ago

I can try the suggested fix in a couple hours. Also on Hyprland fwiw

ThatOneCalculator commented 5 months ago

I'll move the discussion over there since it's definitely a duplicate