search

russfrisch / modernizr-rails

Gem wrapper to include the Modernizr.js library via the Rails 3.1 asset pipeline.
http://rubygems.org/gems/modernizr-rails
MIT License
170 stars 21 forks source link

Allow configuration on the fly #23

Open ream88 opened 11 years ago

ream88 commented 11 years ago

The latest few issues (#19, #20, #21) showed up a big problem of this gem: Not everybody needs the same setup, and some features of Modernizr even break some setups.

A few solutions I thought of:

#= require modernizr # for the whole Modernizr build
#= require modernizr-css # only for the CSS tests
#= require modernizr-touch-events # only for one particular test, in this case touch events

Any ideas and suggestions? @russfrisch @mltsy

russfrisch commented 11 years ago

I agree with your first point and I love the idea of your second point. With the power of Asset Pipeline to combine and minify the various modernizr pieces into a single file I can't think of a reason not to go this route.

Russ Frisch http://about.me/russfrisch

On Fri, Jun 7, 2013 at 4:04 AM, Mario Uher notifications@github.com wrote:

The latest few issues (#19https://github.com/russfrisch/modernizr-rails/issues/19,

20 https://github.com/russfrisch/modernizr-rails/issues/20, #21https://github.com/russfrisch/modernizr-rails/issues/21)

showed up a big problem of this gem: Not everybody needs the same setup, and some features of Modernizr even break some setups.

A few solutions I thought of:

  • I'm only bundling the dev built anymore: If somebody needs a special version of Modernizr, they have to bring their own. We should not accept such pull requests anymore. This is the quickest solution for now, and I will update the README about this change.
  • Some kind of building system: A Modernizr build is assembled by Grunt http://gruntjs.com from lots of separate files. Maybe we can translate this functionality into the Rails Asset Pipeline somehow. Usage would be following:

= require modernizr # for the whole Modernizr build#= require modernizr-css # only for the CSS tests#= require modernizr-touch-events # only for one particular test, in this case touch events

Any ideas and suggestions? @russfrisch https://github.com/russfrisch @mltsy https://github.com/mltsy

— Reply to this email directly or view it on GitHubhttps://github.com/russfrisch/modernizr-rails/issues/23 .