russhwolf / multiplatform-settings

A Kotlin Multiplatform library for saving simple key-value data
Apache License 2.0
1.49k stars 64 forks source link

Use Dispatcher.IO instead of Dispatcher.Default by default #157

Closed kirillzh closed 8 months ago

kirillzh commented 1 year ago

Coroutines KMP now have Dispatcher.IO which seems more suitable as a default dispatcher for SuspendSettings and FlowSettings.

vanniktech commented 1 year ago

Is this a new thing since 1.7? Is it also available on native / ios?

kirillzh commented 1 year ago

Is this a new thing since 1.7? Is it also available on native / ios?

Yup, was added in 1.7 https://github.com/Kotlin/kotlinx.coroutines/pull/3576

russhwolf commented 11 months ago

Sorry to leave this sitting, but yes this makes sense (and better to do now while the coroutine APIs are still experimental). Feel free to open a PR, or I'll get to it at some point over the next few weeks (overdue for a 1.9 update anyway)

russhwolf commented 8 months ago

This was added in version 1.1.0