search

russinnes / fsync-mdc1200-decode

Linux Fleetsync / MCD1200 decoder
GNU General Public License v2.0
14 stars 2 forks source link

overlapped buffering not being used #5

Open leee opened 4 years ago

leee commented 4 years ago

While I was adding support for file input, I was thinking about how I'd handle reading since I figured I could benefit from being able to seek over a static file, something you can't do with streams.

While quickly examining the existing stream handling, it looks like you're just reading in data as received and not really doing any sort of prebuffering and running the decoders on segments of that.

Were you intending on implementing this in the future, or is this an artifact from it's commit 3 years ago and can be removed?

https://github.com/russinnes/fsync-mdc1200-decode/blob/daff2c38cc54243a5b1f26149b34987426c64456/demod.c#L178-L179

russinnes commented 4 years ago

Yes, it was part of a previous version years ago which handle both decoders differently. There are a few stragglers I have not cleaned out yet, it needs a bit of garbage collection.

leee commented 4 years ago

Brilliant - if you have no objections, I'd be glad to do a bit of taking out the trash I see.

russinnes commented 4 years ago

You bet, I'll keep an eye on it now and merge as needed.