search

russmedia-digital / cordova-plugin-google-signin

Cordova Google SignIn
Apache License 2.0
12 stars 29 forks source link

iOS build failing #11

Open jpike88 opened 1 year ago

jpike88 commented 1 year ago

You haven't pinned GoogleSignIn pod, and version 7.0 just got realised (Dec 2022). It's now breaking iOS builds

❌  /Users/[REDACTED]/git/client/cordova/platforms/ios/FormPigeon/Plugins/cordova-plugin-google-signin/GoogleSignInPlugin.m:73:55: property 'authentication' not found on object of type 'GIDGoogleUser *'
                           @"id_token"         : user.authentication.idToken,
            ^
❌  /Users/[REDACTED]/git/client/cordova/platforms/ios/FormPigeon/Plugins/cordova-plugin-google-signin/GoogleSignInPlugin.m:61:13: no visible @interface for 'GIDSignIn' declares the selector 'signInWithConfiguration:presentingViewController:callback:'
    [signIn signInWithConfiguration:config presentingViewController:self.viewController callback:^(GIDGoogleUser * _Nullable user, NSError * _Nullable error) {
                                                      ^
❌  /Users/[REDACTED]/git/client/cordova/platforms/ios/FormPigeon/Plugins/cordova-plugin-google-signin/GoogleSignInPlugin.m:121:31: no visible @interface for 'GIDSignIn' declares the selector 'disconnectWithCallback:'
    [GIDSignIn.sharedInstance disconnectWithCallback:^(NSError * _Nullable error) {
     ~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
PoojaSpiking commented 1 year ago

+1 Along with the above errors, I am also getting use of undeclared identifier errors when I build for iOS.

/Users/[REDACTED]/platforms/ios/Spiking/Plugins/cordova-plugin-google-signin/GoogleSignInPlugin.m:57:5: error: use of undeclared
      identifier 'GIDConfiguration'
    GIDConfiguration *config = [[GIDConfiguration alloc] initWithClientID:clientId];
    ^
/Users/[REDACTED]/platforms/ios/Spiking/Plugins/cordova-plugin-google-signin/GoogleSignInPlugin.m:57:23: error: use of undeclared
      identifier 'config'
    GIDConfiguration *config = [[GIDConfiguration alloc] initWithClientID:clientId];
                      ^
/Users/[REDACTED]/platforms/ios/Spiking/Plugins/cordova-plugin-google-signin/GoogleSignInPlugin.m:57:34: error: use of undeclared
      identifier 'GIDConfiguration'
    GIDConfiguration *config = [[GIDConfiguration alloc] initWithClientID:clientId];
                                 ^
jpike88 commented 1 year ago

https://github.com/aquipa/cordova-plugin-google-signin

I have a fixed fork, just had to pin the google pod versions