russmedia-digital / cordova-plugin-google-signin

Cordova Google SignIn
Apache License 2.0
11 stars 29 forks source link

Use Google Services Gradle Plugin Version 4.3.14 #15

Closed macsplit closed 1 year ago

macsplit commented 1 year ago

This patch will use Google Services Gradle Plugin version 4.3.14 instead of 4.3.10 to address a project build error when using cordova-android 12.

majeed-platogo commented 1 year ago

Hi @macsplit, your work fixes the crash issue. Unfortunately, when I try using the plugin I get the error below.

cordova.plugins.GoogleSignInPlugin.signIn(
  function (authData) {
    console.log(authData);
  },
  function (error) {
    console.error(error);
  }
);
image

What do you think might have gone wrong?

macsplit commented 1 year ago

@majeed-platogo the patch addressed a specific build error I encountered trying to build an android Cordova app with the plugin provided by @russmedia-digital using the new Cordova Android 12 platform, sorry I am unable to diagnose further issues with the crash logs provided

majeed-platogo commented 1 year ago

@majeed-platogo the patch addressed a specific build error I encountered trying to build an android Cordova app with the plugin provided by @russmedia-digital using the new Cordova Android 12 platform, sorry I am unable to diagnose further issues with the crash logs provided

That's fair. However, I would like you to confirm if it works perfectly for you?

macsplit commented 1 year ago

Yes it was working in my case.

majeed-platogo commented 1 year ago

Got it thanks

majeed-platogo commented 1 year ago

The solutions was adding -keep class com.devapps.** {*;} to proguard