russplaysguitar / UnderscoreCF

An UnderscoreJS port for Coldfusion. Functional programming library.
http://russplaysguitar.github.com/UnderscoreCF/
MIT License
89 stars 38 forks source link

Fix unit tests: expected vs. actual ordering #13

Closed russplaysguitar closed 11 years ago

russplaysguitar commented 11 years ago

I think that most of the assertions have the expected/actual values swapped. It was originally done this way because the Underscore.js tests were in this order (which is not a good reason).

This should be fixed, but it is mind numbing work...

For example:

assertEquals(_.flatten(result), [1,2,1,2], 'initial works with _.map');

should be:

assertEquals([1,2,1,2], _.flatten(result), 'initial works with _.map');

See http://wiki.mxunit.org/display/default/Built-In+Assertions

atuttle commented 11 years ago

It may take a day or two to get through them all (lots of tests!) but I will make sure to get ALL of them updated as part of 24PullRequests.

russplaysguitar commented 11 years ago

nice!

russplaysguitar commented 11 years ago

fixed by: 9b67bb6d7ed56a54f8bea2d6bda65f057878a793