Open jfrux opened 7 years ago
I'd be more comfortable with that if we got the build passing. As it is, I'm concerned about stability. #54 almost fixes it, albeit in a way I'm less happy about (relying on Java).
Russ, what if we dropped the dependency on Java and put some of those failing issues in a dev branch? What percentage of the methods require java?
On Feb 9, 2017, at 8:31 PM, Russ notifications@github.com wrote:
I'd be more comfortable with that if we got the build passing. As it is, I'm concerned about stability. #54 https://github.com/russplaysguitar/UnderscoreCF/pull/54 almost fixes it, albeit in a way I'm less happy about (relying on Java).
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/russplaysguitar/UnderscoreCF/issues/56#issuecomment-278831863, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKcRaIblKaQRyjVUTCwmflWszoPvgXEks5ra73VgaJpZM4L8Ma9.
None of the other methods require Java as far as I recall. I intentionally tried not to use Java when creating the library so as to avoid dependency issues (like the ones we're seeing in the failing tests now).
The problem is that I'm not sure there's another way to resolve the issue (easily). The logic (ported from JS) expects the arguments struct to be sorted, but this is not really possible in CF structs. Not sure why this wasn't a problem in CF 10.
I noticed this had a box.json but isn't published to forgebox.io. Would someone be able to do this? Or would you mind if I do it?