russross / blackfriday

Blackfriday: a markdown processor for Go
Other
5.42k stars 598 forks source link

Underlined headings #585

Closed cbednarski closed 4 years ago

cbednarski commented 4 years ago

I am writing unit tests for a project that uses blackfriday, and I noticed that blackfriday does not seem to parse underlined / dashed / setext headings, such as

This is an H1
=============

This is an H2
-------------

Is this a bug, or did I miss a flag somewhere, or is this not implemented? The only reference I have seen to this is in https://github.com/russross/blackfriday/issues/370 which mentions underlined headings.

I'm using v2.0.1

Here's my test case:

Input

This is the Title
-----------------

And this is the first paragraph

Expected

<h2 id="this-is-the-title">This is the Title</h2>

<p>And this is the first paragraph</p>

Actual

   TestReadPage: page_test.go:37: ---- Expected ----
        <h1 id="this-is-the-title">This is the Title</h1>

        <p>And this is the first paragraph</p>

        ---- Found ----
        <hr />

        <p>And this is the first paragraph</p>

Thanks!