search

rust-ammonia / ammonia

Repair and secure untrusted HTML
Apache License 2.0
524 stars 43 forks source link

Prepare 4.0.0 release #195

Closed djc closed 7 months ago

djc commented 7 months ago

Since html5ever appears in the public API, this needs a semver-incompatible version bump.

notriddle commented 7 months ago

Since html5ever appears in the public API

It’s not supposed to. Which function does that?

djc commented 7 months ago

Ah, sorry -- I misread, was looking at the SanitizationTokenizer's TokenSink impl but that is a private type.

So this can just be 3.4.0 I guess?

notriddle commented 7 months ago

Preferably, yes. We want people to immediately update to the newest ammonia as soon as we release it, so we need to have a more stable API than html5ever has.

djc commented 7 months ago

Don't get me wrong, I'm a fan! I've just seen that many maintainers aren't quite so careful about hiding private dependencies.

But, what about the notice in the changelog that says "breaking change" (change lifetimes on UrlRelative)? That's from 32e12a0577fd9013712d40db4b06955b41214579 (which doesn't seem to carry an affiliation with any PR).

notriddle commented 7 months ago

You're right. I had forgotten about that.

It's going to be 4.0 after all, then.