Add DynClone to make the builder cloneable

rust-ammonia / ammonia

Repair and secure untrusted HTML

Apache License 2.0

524 stars 43 forks source link

Add DynClone to make the builder cloneable #205

Open stevefan1999-personal opened 2 months ago

stevefan1999-personal commented 2 months ago

This PR uses https://github.com/dtolnay/dyn-clone and modified some traits to use DynClone, so that eventually the Builder can now be Clone. Notice while the cargo test fully passes for this, this is a potentially ABI breaking change.

notriddle commented 2 months ago

This change makes sense to me, but will definitely require a major version bump.

cc @lnicola