search

rust-analyzer / countme

Apache License 2.0
18 stars 4 forks source link

Shall it include a derive macro to do what README example shows automatically? #1

Closed vi closed 3 years ago

matklad commented 3 years ago

it's going to become way simpler than that actually: https://github.com/matklad/countme/blob/dm/src/dm.rs

vi commented 3 years ago

#[cfg(not(feature = "no-op"))]

Looks like a negative Cargo feature - an anti-pattern.

Maybe better to use positive non-defaulted feature, suggesting users to add it in README.