search

rust-analyzer / rowan

Apache License 2.0
689 stars 57 forks source link

Borrow nodes of immutable syntax trees #101

Closed iDawer closed 3 years ago

iDawer commented 3 years ago

Borrow green nodes of immutable syntax trees. It requires some clarified invariants inside the cursor module. But overall, I think, it is safe for an API consumer.

(I couldn't find the latest 0.13.0-pre.3 version commit. Where should this go?)

lnicola commented 3 years ago

Yeah, 0.13.0-pre.3 was already published, you might want to go to -pre.4 and rebase later: https://crates.io/crates/rowan/versions, https://github.com/rust-analyzer/rust-analyzer/pull/8153/files.

lnicola commented 3 years ago

You can probably rebase now.

matklad commented 3 years ago

LGTM!

iDawer commented 3 years ago

Should I bump version?

matklad commented 3 years ago

merged into master and publishing as pre.4

iDawer commented 3 years ago

Whoops, seems like this PR recreated the clone-for-update branch, and now the published version does not contain the changes

matklad commented 3 years ago

heh, @matklad: 0, git: 1.

master should be better now