rust-analyzer / rowan

Apache License 2.0
689 stars 57 forks source link

Use some ptr::addr_of_mut for taking ptr addr #109

Closed CAD97 closed 3 years ago

CAD97 commented 3 years ago

Relevant to #108, but I'm not certain if it addresses the miri failure or not. (Can't check because of https://github.com/rust-lang/miri/issues/705.)

Either way, this is a positive change, as previously we were creating &mut to uninitialized memory locations.

pandaman64 commented 3 years ago

I confirmed that this patch fixes #108. Thanks!

lnicola commented 3 years ago

Can you update the version in Cargo.toml?

CAD97 commented 3 years ago

Version bumped

lnicola commented 3 years ago

bors r+

bors[bot] commented 3 years ago

Build succeeded:

lnicola commented 3 years ago

And it's published, thanks!