search

rust-analyzer / rowan

Apache License 2.0
689 stars 57 forks source link

Fix NodeCache which reduced caching efficiency, while making it faster #111

Closed matklad closed 3 years ago

matklad commented 3 years ago

Turns out that we accidentally use two different hash functions in NodeCache, which is wrong in a fun way. This was discovered while trying to optimize equality to be based on pointer comparisons.

See https://youtu.be/bVoHUzswKog for details

bors r+

bors[bot] commented 3 years ago

Build succeeded:

CAD97 commented 3 years ago

Whoops! :smile:

matklad commented 3 years ago

Indeed!