fix: Fix memory leak in NodeData constructor

rust-analyzer / rowan

Apache License 2.0

689 stars 57 forks source link

Closed Veykril closed 3 years ago

Veykril commented 3 years ago

Drop SyntaxNode in mutable trees when reusing a NodeData

Veykril commented 3 years ago

bors r+

bors[bot] commented 3 years ago

Build succeeded:

matklad commented 3 years ago

Oh wow, I thought that my caching bug was bad, but this seems worse, awesome job @Veykril

Veykril commented 3 years ago

This was hiding pretty well, took quite some time to find.