Replace `SyntaxKind` with `Into<SyntaxKind>` in function parameters

rust-analyzer / rowan

Apache License 2.0

715 stars 61 forks source link

Replace `SyntaxKind` with `Into<SyntaxKind>` in function parameters #145

Open spencerwhite opened 2 years ago

spencerwhite commented 2 years ago

It would be much more convenient to write builder.start_node(Ast::Expr) than builder.start_node(Ast::Expr.into()), assuming there is an impl From<Ast> for SyntaxKind somewhere. Obviously not a huge deal, but it would slightly cut down on boilerplate.