search

rust-analyzer / rowan

Apache License 2.0
697 stars 57 forks source link

Fix SyntaxText equality #37

Closed Matthias247 closed 4 years ago

Matthias247 commented 4 years ago

This returned that Strings are equal for quite a lot of strings which were actually not equal at all. That lead Rust Analyzer to provide assists at times where it shouldn't have - e.g. it allowed to merge match arms which actually did not contain the same expression.

bors[bot] commented 4 years ago

Already running a review

Matthias247 commented 4 years ago

I actually remember considering writing a property test here, but thought that a handful of manual tests would do the trick.

Typically they do. But one shouldn't forget to also add some negative test cases :-)

bors[bot] commented 4 years ago

Build succeeded