rust-analyzer / rowan

Apache License 2.0

697 stars 57 forks source link

Hide green element storage mechanism in GreenNode::children #40

Closed CAD97 closed 4 years ago

CAD97 commented 4 years ago

On top of #39. This is the main reason for splitting out new piecewise PRs, as this is the major breaking change required for changing the GreenElement internal packed representation from enum NodeOrToken.

r? @matklad

matklad commented 4 years ago

bors r-

Hm, there's one thing I want to do here:let's bump version in Cargo.toml

bors[bot] commented 4 years ago

Canceled

CAD97 commented 4 years ago

@matklad nits addressed

Let's remind myself whether I can do this...

bors: r+

bors[bot] commented 4 years ago

:lock: Permission denied

Existing reviewers: click here to make CAD97 a reviewer

matklad commented 4 years ago

grantid github perms. Accept the invite and ping me to kick bors perm sync

CAD97 commented 4 years ago

@matklad accepted

matklad commented 4 years ago

Ook, try r+ again?

CAD97 commented 4 years ago

bors: r=matklad

bors[bot] commented 4 years ago

Build succeeded

continuous-integration/travis-ci/push

CAD97 commented 4 years ago

@matklad before you publish, we should hide the use of SmolStr as well

matklad commented 4 years ago

@CAD97 I'd rather postpone that, as it would be a pretty big invasive change for rust-analyzer, and it would be interesting to measure the effects of tail-allocating the string separatelly.

CAD97 commented 4 years ago

Got it!

matklad commented 4 years ago

https://github.com/rust-analyzer/rust-analyzer/pull/2314 updates to 0.7 in ra