Rename serde feature flag to `serde`

rust-analyzer / rowan

Apache License 2.0

697 stars 57 forks source link

Closed CAD97 closed 3 years ago

CAD97 commented 4 years ago

The serde1 feature flag should be removed with the next version bump.

(I'm working on a proof of implementing rowan's green tree by wrapping sorbus's green tree, so that will probably be the next version bump.)

matklad commented 3 years ago

Looking at this more, I think we shouldn't do this.

In the grand scheme of things, this doesn't matter
I am not a huge fan of work-around personally. Between a nice API with awkward implementation and somewhat awkward API with nice impl, I prefer the second case for all but the most re-usable crates.