search

rust-analyzer / rowan

Apache License 2.0
689 stars 57 forks source link

Consider using (or offering using) nonstandard Arc without weak support #78

Closed CAD97 closed 3 years ago

CAD97 commented 3 years ago

e.g. triomphe, elysees, or a custom one.

Our usage of Arc is currently entirely contained, so this could be done transparently. The alternate backend of sorbus exposes Arc, so would make this harder to do.

@RDambrosio016 reports a 55% (!) (valgrind-reported) drop in memory usage for switching to an Arc without weak reference support.

CAD97 commented 3 years ago

I think this is done now that we're using a custom arc? @matklad

matklad commented 3 years ago

Ideed!