rust-analyzer / rust-analyzer.github.io

https://rust-analyzer.github.io/
87 stars 51 forks source link

Add Kakoune and Helix configuration #181

Closed woshilapin closed 2 years ago

woshilapin commented 2 years ago

Fixes #180.

I choose to put links to existing official documentation instead of copy/paste what to do with the risk of being out-of-date (especially for these young editors where things move often).

lnicola commented 2 years ago

Please add hard line breaks after each sentence, it makes reading diffs much easier.

And I'm not sure about the helix remark/emoji. I don't mind them that much, but they don't really fit the style used in the rest of the docs.

woshilapin commented 2 years ago

Please add hard line breaks after each sentence, it makes reading diffs much easier.

Indeed, done.

And I'm not sure about the helix remark/emoji. I don't mind them that much, but they don't really fit the style used in the rest of the docs.

I might have been a bit too comfortable here :sweat_smile: Let's say it was late yesterday evening! I removed it.

lnicola commented 2 years ago

bors d+

changelog fix (first contribution) add install instructions for Kakoune and Helix.

bors[bot] commented 2 years ago

:v: woshilapin can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

woshilapin commented 2 years ago

bors r+

bors[bot] commented 2 years ago

Configuration problem: bors.toml: not found

woshilapin commented 2 years ago

First time I interact with bors. I thought I was allowed to do bors r+ after @lnicola did bors d+, but seems like there is a problem. Did I do something wrong?

lnicola commented 2 years ago

Sorry I didn't notice it, can you port your changes to https://github.com/rust-analyzer/rust-analyzer/blob/master/docs/user/manual.adoc?

There is a comment at the top:

IMPORTANT: the master copy of this document lives in the https://github.com/rust-analyzer/rust-analyzer repository
woshilapin commented 2 years ago

New PR opened in https://github.com/rust-analyzer/rust-analyzer/pull/11535.