Implement decoding via ffmpeg

rust-av / av-metrics

Quality metrics

MIT License

53 stars 9 forks source link

Implement decoding via ffmpeg #218

Closed shssoichiro closed 3 years ago

shssoichiro commented 3 years ago

This is enabled via a compile-time feature flag, due to limitations with traits and generic parameters. Ffmpeg allows the decoding of arbitrary video formats. The default remains to use the y4m decoder only, since ffmpeg depends on an external C library.

lu-zero commented 3 years ago

This goes against my effort of moving the decoders in the binary and keep the library just about metrics. Can we try split the two concerns?

shssoichiro commented 3 years ago

Yes, I'll see what I can do in regard to moving the decoders out of the library.

shssoichiro commented 3 years ago

I moved the decoders to their own crate, exposed the Decoder trait by default (no longer behind a feature), and split the commits in a way that made sense to me. I had to keep the CI changes paired with the addition of ffmpeg, because that is the part that required the CI changes.

lu-zero commented 3 years ago

The benchmarks need an update, beside that it is nice :)